<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: Improve the safety of playback toggling"
href="https://bugs.webkit.org/show_bug.cgi?id=145986#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: Improve the safety of playback toggling"
href="https://bugs.webkit.org/show_bug.cgi?id=145986">bug 145986</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=145986#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=254891&action=diff" name="attach_254891" title="Patch">attachment 254891</a> <a href="attachment.cgi?id=254891&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=254891&action=review">https://bugs.webkit.org/attachment.cgi?id=254891&action=review</a>
>
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:97
> > + ASSERT(!m_iteratedActiveParticipatingElements);
>
> What guarantees this won’t happen? I’d think that if we make something play
> that some events might fire and in response we might run some code and end
> up back here.
>
> Maybe we need to handle this case, perhaps by doing nothing?</span >
This assertion is in the MediaSession::togglePlayback method which is currently only called in response to play/pause media keys. This method will never call itself.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>