[Webkit-unassigned] [Bug 145986] Media Session: Improve the safety of playback toggling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 15:10:18 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=145986

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254891|review?                     |review+
              Flags|                            |

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 254891
  --> https://bugs.webkit.org/attachment.cgi?id=254891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254891&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:97
> +    ASSERT(!m_iteratedActiveParticipatingElements);

What guarantees this won’t happen? I’d think that if we make something play that some events might fire and in response we might run some code and end up back here.

Maybe we need to handle this case, perhaps by doing nothing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150615/db2ab922/attachment.html>


More information about the webkit-unassigned mailing list