[Webkit-unassigned] [Bug 145598] [GTK] Get rid of GetEditorCommandsForKeyEvent sync message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145598

--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 254159
  --> https://bugs.webkit.org/attachment.cgi?id=254159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254159&action=review

> Source/WebCore/dom/KeyboardEvent.cpp:233
> +#if PLATFORM(GTK)
> +bool KeyboardEvent::handledByInputMethod() const
> +{
> +    return m_keyEvent ? m_keyEvent->handledByInputMethod() : false;
> +}
> +#endif

Why not use the m_handledByInputMethod boolean, like it's used for the Cocoa platform?

> Source/WebKit2/UIProcess/gtk/InputMethodFilter.h:58
> +    typedef std::function<void (const WebCore::CompositionResults&, InputMethodFilter::EventFakedForComposition)> FilterKeyEventCompletionHandler;

using FilterKeyEventCompletionHandler = std::function<...>;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150610/fa3084aa/attachment.html>