[Webkit-unassigned] [Bug 145598] [GTK] Get rid of GetEditorCommandsForKeyEvent sync message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145598

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 254159 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254159&action=review
> 
> > Source/WebCore/dom/KeyboardEvent.cpp:233
> > +#if PLATFORM(GTK)
> > +bool KeyboardEvent::handledByInputMethod() const
> > +{
> > +    return m_keyEvent ? m_keyEvent->handledByInputMethod() : false;
> > +}
> > +#endif
> 
> Why not use the m_handledByInputMethod boolean, like it's used for the Cocoa
> platform?

Because we don't need to duplicate that, this is just a convenient method, to avoid having to get the platform event, check if it's null, and then get the boolean.

> > Source/WebKit2/UIProcess/gtk/InputMethodFilter.h:58
> > +    typedef std::function<void (const WebCore::CompositionResults&, InputMethodFilter::EventFakedForComposition)> FilterKeyEventCompletionHandler;
> 
> using FilterKeyEventCompletionHandler = std::function<...>;

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150610/fb9ab30e/attachment.html>