<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Get rid of GetEditorCommandsForKeyEvent sync message"
href="https://bugs.webkit.org/show_bug.cgi?id=145598#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Get rid of GetEditorCommandsForKeyEvent sync message"
href="https://bugs.webkit.org/show_bug.cgi?id=145598">bug 145598</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=254159&action=diff" name="attach_254159" title="Patch">attachment 254159</a> <a href="attachment.cgi?id=254159&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=254159&action=review">https://bugs.webkit.org/attachment.cgi?id=254159&action=review</a>
<span class="quote">> Source/WebCore/dom/KeyboardEvent.cpp:233
> +#if PLATFORM(GTK)
> +bool KeyboardEvent::handledByInputMethod() const
> +{
> + return m_keyEvent ? m_keyEvent->handledByInputMethod() : false;
> +}
> +#endif</span >
Why not use the m_handledByInputMethod boolean, like it's used for the Cocoa platform?
<span class="quote">> Source/WebKit2/UIProcess/gtk/InputMethodFilter.h:58
> + typedef std::function<void (const WebCore::CompositionResults&, InputMethodFilter::EventFakedForComposition)> FilterKeyEventCompletionHandler;</span >
using FilterKeyEventCompletionHandler = std::function<...>;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>