[Webkit-unassigned] [Bug 144955] [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 3 14:12:22 PDT 2015


--- Comment #40 from Darin Adler <darin at apple.com> ---
(In reply to comment #39)
> 1. Source/JavaScriptCore/parser/ParserTokens.h:79
> I've added new value ARROWFUNCTION and followed the same style as all enums
> in this file
> http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/parser/
> ParserTokens.h#L75

This one is really strange. I’m not sure why we decided to use all caps for all these tokens. Worth discussing with someone, but for now I suppose you should match the style.

> 2. Source/JavaScriptCore/parser/Parser.h 
> In this file I've added new parameter with default value in exist function.
> I've used default value to decrease number of changes, so to default value I
> had to add name of the parameter.
> template <class TreeBuilder> TreeStatement parseStatement(TreeBuilder&,
> const Identifier*& directive, unsigned* directiveLiteralLength = 0,
> !!!!FunctionParseType functionParseType = StandardFunctionParseType!!!!)

You don’t need am argument name to have a default value:

    [...] unsigned* directiveLiteralLength = nullptr, FunctionParseType = StandardFunctionParseType)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150603/ce777cf6/attachment.html>

More information about the webkit-unassigned mailing list