<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955#c40">Comment # 40</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function"
href="https://bugs.webkit.org/show_bug.cgi?id=144955">bug 144955</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144955#c39">comment #39</a>)
<span class="quote">> 1. Source/JavaScriptCore/parser/ParserTokens.h:79
> I've added new value ARROWFUNCTION and followed the same style as all enums
> in this file
> <a href="http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/parser/">http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/parser/</a>
> ParserTokens.h#L75</span >
This one is really strange. I’m not sure why we decided to use all caps for all these tokens. Worth discussing with someone, but for now I suppose you should match the style.
<span class="quote">> 2. Source/JavaScriptCore/parser/Parser.h
> In this file I've added new parameter with default value in exist function.
> I've used default value to decrease number of changes, so to default value I
> had to add name of the parameter.
>
> template <class TreeBuilder> TreeStatement parseStatement(TreeBuilder&,
> const Identifier*& directive, unsigned* directiveLiteralLength = 0,
> !!!!FunctionParseType functionParseType = StandardFunctionParseType!!!!)</span >
You don’t need am argument name to have a default value:
[...] unsigned* directiveLiteralLength = nullptr, FunctionParseType = StandardFunctionParseType)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>