[Webkit-unassigned] [Bug 147008] Media Session: add support for platform-specific interruption providers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147008

--- Comment #6 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #5)
> Comment on attachment 256916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256916&action=review
> 
> > Source/WebCore/platform/audio/MediaSessionInterruptionProvider.h:57
> > +    // To be overriden by subclasses.
> > +    virtual void beginListeningForInterruptions();
> > +    virtual void stopListeningForInterruptions();
> 
> If these must be overridden, why not make the pure-virtual?

These methods are called from the base class's constructor and destructor so they cannot be pure virtual.

> 
> > Source/WebCore/platform/audio/mac/MediaSessionInterruptionProviderMac.h:37
> > +    using MediaSessionInterruptionProvider::MediaSessionInterruptionProvider;
> 
> Is this necessary?

Yes, constructors aren't inherited.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150716/471e9d2f/attachment.html>