<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add support for platform-specific interruption providers"
href="https://bugs.webkit.org/show_bug.cgi?id=147008#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: add support for platform-specific interruption providers"
href="https://bugs.webkit.org/show_bug.cgi?id=147008">bug 147008</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=147008#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256916&action=diff" name="attach_256916" title="Patch">attachment 256916</a> <a href="attachment.cgi?id=256916&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256916&action=review">https://bugs.webkit.org/attachment.cgi?id=256916&action=review</a>
>
> > Source/WebCore/platform/audio/MediaSessionInterruptionProvider.h:57
> > + // To be overriden by subclasses.
> > + virtual void beginListeningForInterruptions();
> > + virtual void stopListeningForInterruptions();
>
> If these must be overridden, why not make the pure-virtual?</span >
These methods are called from the base class's constructor and destructor so they cannot be pure virtual.
<span class="quote">>
> > Source/WebCore/platform/audio/mac/MediaSessionInterruptionProviderMac.h:37
> > + using MediaSessionInterruptionProvider::MediaSessionInterruptionProvider;
>
> Is this necessary?</span >
Yes, constructors aren't inherited.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>