[Webkit-unassigned] [Bug 147008] Media Session: add support for platform-specific interruption providers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147008

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256916|review?                     |review+
              Flags|                            |

--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 256916
  --> https://bugs.webkit.org/attachment.cgi?id=256916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256916&action=review

> Source/WebCore/platform/audio/MediaSessionInterruptionProvider.h:57
> +    // To be overriden by subclasses.
> +    virtual void beginListeningForInterruptions();
> +    virtual void stopListeningForInterruptions();

If these must be overridden, why not make the pure-virtual?

> Source/WebCore/platform/audio/mac/MediaSessionInterruptionProviderMac.h:37
> +    using MediaSessionInterruptionProvider::MediaSessionInterruptionProvider;

Is this necessary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150716/d6e851da/attachment-0001.html>