[Webkit-unassigned] [Bug 146917] iOS WebKit doesn't build.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146917

--- Comment #8 from Yongjun Zhang <yongjun_zhang at apple.com> ---
(In reply to comment #7)
> Comment on attachment 256734 [details]
> Fix the conflict.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256734&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197
> > +    _previewing.delegate = nil;
> >      [_previewGestureRecognizer setDelegate:nil];
> >      _previewGestureRecognizer = nil;
> > +    [_previewing release];
> 
> Should we do these two new things (clearing the delegate and releasing) in
> our -dealloc too, just in case?

I don't think it's needed. We will do the cleanup when the view is removed from window, which should be done before dealloc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150714/f3c4fb03/attachment.html>