<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS WebKit doesn't build."
href="https://bugs.webkit.org/show_bug.cgi?id=146917#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS WebKit doesn't build."
href="https://bugs.webkit.org/show_bug.cgi?id=146917">bug 146917</a>
from <span class="vcard"><a class="email" href="mailto:yongjun_zhang@apple.com" title="Yongjun Zhang <yongjun_zhang@apple.com>"> <span class="fn">Yongjun Zhang</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146917#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256734&action=diff" name="attach_256734" title="Fix the conflict.">attachment 256734</a> <a href="attachment.cgi?id=256734&action=edit" title="Fix the conflict.">[details]</a></span>
> Fix the conflict.
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256734&action=review">https://bugs.webkit.org/attachment.cgi?id=256734&action=review</a>
>
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197
> > + _previewing.delegate = nil;
> > [_previewGestureRecognizer setDelegate:nil];
> > _previewGestureRecognizer = nil;
> > + [_previewing release];
>
> Should we do these two new things (clearing the delegate and releasing) in
> our -dealloc too, just in case?</span >
I don't think it's needed. We will do the cleanup when the view is removed from window, which should be done before dealloc.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>