[Webkit-unassigned] [Bug 146917] iOS WebKit doesn't build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 13 15:50:30 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146917

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256734|commit-queue+               |review+
              Flags|                            |

--- Comment #7 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 256734
  --> https://bugs.webkit.org/attachment.cgi?id=256734
Fix the conflict.

View in context: https://bugs.webkit.org/attachment.cgi?id=256734&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197
> +    _previewing.delegate = nil;
>      [_previewGestureRecognizer setDelegate:nil];
>      _previewGestureRecognizer = nil;
> +    [_previewing release];

Should we do these two new things (clearing the delegate and releasing) in our -dealloc too, just in case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150713/924d01df/attachment.html>


More information about the webkit-unassigned mailing list