[Webkit-unassigned] [Bug 146916] Input buttons rendered at the wrong size when pinching-to-zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146916

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 256770
  --> https://bugs.webkit.org/attachment.cgi?id=256770
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256770&action=review

>> Source/WebCore/platform/mac/ThemeMac.mm:574
>> +    std::unique_ptr<ImageBuffer> imageBuffer = nullptr;
> 
> No need to initialize with nullptr.

Got it. Fixed!

>> Source/WebCore/platform/mac/ThemeMac.mm:603
>> +            std::unique_ptr<ImageBuffer> focusRectImageBuffer = ImageBuffer::createCompatibleBuffer(inflatedRect.size() + 2 * FloatSize(focusWidth, focusWidth), deviceScaleFactor, ColorSpaceDeviceRGB, context, false);
> 
> Can we just draw the buttonCell and the focus ring into the same buffer? Just need to make a larger buffer up front.

Sounds good. Done!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150714/ccdcc24a/attachment-0001.html>