<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Input buttons rendered at the wrong size when pinching-to-zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=146916#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Input buttons rendered at the wrong size when pinching-to-zoom"
href="https://bugs.webkit.org/show_bug.cgi?id=146916">bug 146916</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=256770&action=diff" name="attach_256770" title="Patch">attachment 256770</a> <a href="attachment.cgi?id=256770&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=256770&action=review">https://bugs.webkit.org/attachment.cgi?id=256770&action=review</a>
<span class="quote">>> Source/WebCore/platform/mac/ThemeMac.mm:574
>> + std::unique_ptr<ImageBuffer> imageBuffer = nullptr;
>
> No need to initialize with nullptr.</span >
Got it. Fixed!
<span class="quote">>> Source/WebCore/platform/mac/ThemeMac.mm:603
>> + std::unique_ptr<ImageBuffer> focusRectImageBuffer = ImageBuffer::createCompatibleBuffer(inflatedRect.size() + 2 * FloatSize(focusWidth, focusWidth), deviceScaleFactor, ColorSpaceDeviceRGB, context, false);
>
> Can we just draw the buttonCell and the focus ring into the same buffer? Just need to make a larger buffer up front.</span >
Sounds good. Done!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>