[Webkit-unassigned] [Bug 146660] Media Session: propagate metadata changes to UI clients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146660

--- Comment #12 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #11)
> Comment on attachment 256318 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256318&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKMediaSessionMetadata.cpp:49
> > +    return 0;
> 
> These should be nullptr, not 0, I think?

Fixed. Not sure why we were using 0 in other WK* sources.

> 
> > Source/WebKit2/UIProcess/API/C/WKPageUIClient.h:456
> > +    WKPageMediaSessionMetadataDidChangeCallback                         mediaSessionMetadataDidChange;
> 
> Please make sure that it's OK to add this without bumping the version number
> and that you do everything necessary to not break internal builds because of
> it.

I'll watch the bots. Looks like Brady added a few callbacks last month and things were okay.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150707/570f300a/attachment.html>