[Webkit-unassigned] [Bug 146660] Media Session: propagate metadata changes to UI clients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146660

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256318|review?                     |review+
              Flags|                            |

--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 256318
  --> https://bugs.webkit.org/attachment.cgi?id=256318
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256318&action=review

> Source/WebKit2/UIProcess/API/C/WKMediaSessionMetadata.cpp:49
> +    return 0;

These should be nullptr, not 0, I think?

> Source/WebKit2/UIProcess/API/C/WKPageUIClient.h:456
> +    WKPageMediaSessionMetadataDidChangeCallback                         mediaSessionMetadataDidChange;

Please make sure that it's OK to add this without bumping the version number and that you do everything necessary to not break internal builds because of it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150707/e6186040/attachment.html>