<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Session: propagate metadata changes to UI clients"
href="https://bugs.webkit.org/show_bug.cgi?id=146660">bug 146660</a>
from <span class="vcard"><a class="email" href="mailto:mrajca@apple.com" title="Matt Rajca <mrajca@apple.com>"> <span class="fn">Matt Rajca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146660#c11">comment #11</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=256318&action=diff" name="attach_256318" title="Patch">attachment 256318</a> <a href="attachment.cgi?id=256318&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=256318&action=review">https://bugs.webkit.org/attachment.cgi?id=256318&action=review</a>
>
> > Source/WebKit2/UIProcess/API/C/WKMediaSessionMetadata.cpp:49
> > + return 0;
>
> These should be nullptr, not 0, I think?</span >
Fixed. Not sure why we were using 0 in other WK* sources.
<span class="quote">>
> > Source/WebKit2/UIProcess/API/C/WKPageUIClient.h:456
> > + WKPageMediaSessionMetadataDidChangeCallback mediaSessionMetadataDidChange;
>
> Please make sure that it's OK to add this without bumping the version number
> and that you do everything necessary to not break internal builds because of
> it.</span >
I'll watch the bots. Looks like Brady added a few callbacks last month and things were okay.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>