[Webkit-unassigned] [Bug 146538] Memory leak for a protected element having pending events in ImageLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146538

--- Comment #3 from kyounga <kyounga.ra at gmail.com> ---
(In reply to comment #2)
> Comment on attachment 255984 [details]
> Use RefPtr not calling ref/deref() directly
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255984&action=review
> 
> > Source/WebCore/loader/ImageLoader.cpp:363
> > +            m_protectedElement= &element();
> 
> Type: Missing a space before the =.
> 
> (Really bummed that check-webkit-style didn't get this)
> 
> > Source/WebCore/loader/ImageLoader.cpp:372
> > +    m_protectedElement.clear();
> 
> This should be:
> m_protectedElement = nullptr;


m_protectedElement is RefPtr.
clear() will clear the internal pointer to nullptr.

I will change the typo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150702/146a0c27/attachment.html>