[Webkit-unassigned] [Bug 146538] Memory leak for a protected element having pending events in ImageLoader
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 1 22:19:06 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=146538
--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 255984
--> https://bugs.webkit.org/attachment.cgi?id=255984
Use RefPtr not calling ref/deref() directly
View in context: https://bugs.webkit.org/attachment.cgi?id=255984&action=review
> Source/WebCore/loader/ImageLoader.cpp:363
> + m_protectedElement= &element();
Type: Missing a space before the =.
(Really bummed that check-webkit-style didn't get this)
> Source/WebCore/loader/ImageLoader.cpp:372
> + m_protectedElement.clear();
This should be:
m_protectedElement = nullptr;
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150702/e598e0e9/attachment.html>
More information about the webkit-unassigned
mailing list