<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory leak for a protected element having pending events in ImageLoader"
href="https://bugs.webkit.org/show_bug.cgi?id=146538#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory leak for a protected element having pending events in ImageLoader"
href="https://bugs.webkit.org/show_bug.cgi?id=146538">bug 146538</a>
from <span class="vcard"><a class="email" href="mailto:kyounga.ra@gmail.com" title="kyounga <kyounga.ra@gmail.com>"> <span class="fn">kyounga</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=146538#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=255984&action=diff" name="attach_255984" title="Use RefPtr not calling ref/deref() directly">attachment 255984</a> <a href="attachment.cgi?id=255984&action=edit" title="Use RefPtr not calling ref/deref() directly">[details]</a></span>
> Use RefPtr not calling ref/deref() directly
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=255984&action=review">https://bugs.webkit.org/attachment.cgi?id=255984&action=review</a>
>
> > Source/WebCore/loader/ImageLoader.cpp:363
> > + m_protectedElement= &element();
>
> Type: Missing a space before the =.
>
> (Really bummed that check-webkit-style didn't get this)
>
> > Source/WebCore/loader/ImageLoader.cpp:372
> > + m_protectedElement.clear();
>
> This should be:
> m_protectedElement = nullptr;</span >
m_protectedElement is RefPtr.
clear() will clear the internal pointer to nullptr.
I will change the typo.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>