[Webkit-unassigned] [Bug 151831] Hook up request and show for typing candidates in WK1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151831

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #5)
> Comment on attachment 266571 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266571&action=review
> 
> The patch looks good to me.
> 
> > Source/WebCore/page/EditorClient.h:191
> > +    virtual int requestCandidatesForSelection(const VisibleSelection&) = 0;
> 
> Why having an int return type since the only place this is called in Editor
> doesn't check the return value?

Thanks Enrica! I removed the return value.

http://trac.webkit.org/changeset/193645

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151207/266b1e12/attachment.html>