<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Hook up request and show for typing candidates in WK1"
href="https://bugs.webkit.org/show_bug.cgi?id=151831">bug 151831</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Hook up request and show for typing candidates in WK1"
href="https://bugs.webkit.org/show_bug.cgi?id=151831#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Hook up request and show for typing candidates in WK1"
href="https://bugs.webkit.org/show_bug.cgi?id=151831">bug 151831</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151831#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=266571&action=diff" name="attach_266571" title="Patch">attachment 266571</a> <a href="attachment.cgi?id=266571&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=266571&action=review">https://bugs.webkit.org/attachment.cgi?id=266571&action=review</a>
>
> The patch looks good to me.
>
> > Source/WebCore/page/EditorClient.h:191
> > + virtual int requestCandidatesForSelection(const VisibleSelection&) = 0;
>
> Why having an int return type since the only place this is called in Editor
> doesn't check the return value?</span >
Thanks Enrica! I removed the return value.
<a href="http://trac.webkit.org/changeset/193645">http://trac.webkit.org/changeset/193645</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>