[Webkit-unassigned] [Bug 151831] Hook up request and show for typing candidates in WK1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151831

Enrica Casucci <enrica at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266571|review?                     |review+
              Flags|                            |

--- Comment #5 from Enrica Casucci <enrica at apple.com> ---
Comment on attachment 266571
  --> https://bugs.webkit.org/attachment.cgi?id=266571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266571&action=review

The patch looks good to me.

> Source/WebCore/page/EditorClient.h:191
> +    virtual int requestCandidatesForSelection(const VisibleSelection&) = 0;

Why having an int return type since the only place this is called in Editor doesn't check the return value?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151207/136f4374/attachment.html>