[Webkit-unassigned] [Bug 148373] Create WebAssembly functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148373

--- Comment #9 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
(In reply to comment #8)
> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:110
> > +        m_hash = CodeBlockHash(ownerScriptExecutable()->source(), specializationKind());
> 
> In future, it is best to separate a renaming change like this from the
> functionality change in the rest of this patch, and put the two in two
> separate patches.

Thanks. Will do.

> > Source/JavaScriptCore/runtime/Executable.cpp:614
> > +    m_jitCodeForCallWithArityCheck = MacroAssemblerCodePtr();
> > +    m_jitCodeForCallWithArityCheckAndPreserveRegs = MacroAssemblerCodePtr();
> 
> Are you going to fill these in in a separate patch? We're going to need
> them, I think.

I am going to implement the arity check in a separate patch. But these two lines will stay the same, just like what we currently have in ScriptExecutable::installCode(). These two variables are just cached results, I think. ExecutableBase::entrypointFor() will fill them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150827/df2d9b40/attachment-0001.html>