<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373">bug 148373</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=148373#c8">comment #8</a>)
<span class="quote">> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:110
> > + m_hash = CodeBlockHash(ownerScriptExecutable()->source(), specializationKind());
>
> In future, it is best to separate a renaming change like this from the
> functionality change in the rest of this patch, and put the two in two
> separate patches.</span >
Thanks. Will do.
<span class="quote">> > Source/JavaScriptCore/runtime/Executable.cpp:614
> > + m_jitCodeForCallWithArityCheck = MacroAssemblerCodePtr();
> > + m_jitCodeForCallWithArityCheckAndPreserveRegs = MacroAssemblerCodePtr();
>
> Are you going to fill these in in a separate patch? We're going to need
> them, I think.</span >
I am going to implement the arity check in a separate patch. But these two lines will stay the same, just like what we currently have in ScriptExecutable::installCode(). These two variables are just cached results, I think. ExecutableBase::entrypointFor() will fill them.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>