[Webkit-unassigned] [Bug 148373] Create WebAssembly functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148373

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260021|review?                     |review+
              Flags|                            |

--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 260021
  --> https://bugs.webkit.org/attachment.cgi?id=260021
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260021&action=review

r=me

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:110
> +        m_hash = CodeBlockHash(ownerScriptExecutable()->source(), specializationKind());

In future, it is best to separate a renaming change like this from the functionality change in the rest of this patch, and put the two in two separate patches.

> Source/JavaScriptCore/runtime/Executable.cpp:614
> +    m_jitCodeForCallWithArityCheck = MacroAssemblerCodePtr();
> +    m_jitCodeForCallWithArityCheckAndPreserveRegs = MacroAssemblerCodePtr();

Are you going to fill these in in a separate patch? We're going to need them, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150827/b6b6ea45/attachment.html>