<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373">bug 148373</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260021 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Create WebAssembly functions"
href="https://bugs.webkit.org/show_bug.cgi?id=148373">bug 148373</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260021&action=diff" name="attach_260021" title="Patch">attachment 260021</a> <a href="attachment.cgi?id=260021&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260021&action=review">https://bugs.webkit.org/attachment.cgi?id=260021&action=review</a>
r=me
<span class="quote">> Source/JavaScriptCore/bytecode/CodeBlock.cpp:110
> + m_hash = CodeBlockHash(ownerScriptExecutable()->source(), specializationKind());</span >
In future, it is best to separate a renaming change like this from the functionality change in the rest of this patch, and put the two in two separate patches.
<span class="quote">> Source/JavaScriptCore/runtime/Executable.cpp:614
> + m_jitCodeForCallWithArityCheck = MacroAssemblerCodePtr();
> + m_jitCodeForCallWithArityCheckAndPreserveRegs = MacroAssemblerCodePtr();</span >
Are you going to fill these in in a separate patch? We're going to need them, I think.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>