[Webkit-unassigned] [Bug 148501] iOS Simulator API tests fails as Simulator is not running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148501

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260008|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 260008
  --> https://bugs.webkit.org/attachment.cgi?id=260008
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260008&action=review

r- to address issue with simulator not quitting when running dumpTestsBySuite().  If dumpTestsBySuite() needs the simulator, then we need another call to quitIOSSimulator().

> Tools/Scripts/run-api-tests:100
> +relaunchIOSSimulator(findOrCreateSimulatorForIOSDevice(SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT)) if willUseIOSSimulatorSDKWhenBuilding();

The simulator is not stopped if dumpTestsBySuite() is called below.

I think this line should move down to just before the 'exit' line, or into runTestsBySuite() if dumpTestsBySuite() does not need the simulator running.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150827/1ddb873a/attachment.html>