<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS Simulator API tests fails as Simulator is not running"
href="https://bugs.webkit.org/show_bug.cgi?id=148501">bug 148501</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260008 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS Simulator API tests fails as Simulator is not running"
href="https://bugs.webkit.org/show_bug.cgi?id=148501#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - iOS Simulator API tests fails as Simulator is not running"
href="https://bugs.webkit.org/show_bug.cgi?id=148501">bug 148501</a>
from <span class="vcard"><a class="email" href="mailto:ddkilzer@webkit.org" title="David Kilzer (:ddkilzer) <ddkilzer@webkit.org>"> <span class="fn">David Kilzer (:ddkilzer)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260008&action=diff" name="attach_260008" title="Proposed patch">attachment 260008</a> <a href="attachment.cgi?id=260008&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260008&action=review">https://bugs.webkit.org/attachment.cgi?id=260008&action=review</a>
r- to address issue with simulator not quitting when running dumpTestsBySuite(). If dumpTestsBySuite() needs the simulator, then we need another call to quitIOSSimulator().
<span class="quote">> Tools/Scripts/run-api-tests:100
> +relaunchIOSSimulator(findOrCreateSimulatorForIOSDevice(SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT)) if willUseIOSSimulatorSDKWhenBuilding();</span >
The simulator is not stopped if dumpTestsBySuite() is called below.
I think this line should move down to just before the 'exit' line, or into runTestsBySuite() if dumpTestsBySuite() does not need the simulator running.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>