[Webkit-unassigned] [Bug 148501] iOS Simulator API tests fails as Simulator is not running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148501

--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 260008
  --> https://bugs.webkit.org/attachment.cgi?id=260008
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260008&action=review

> Tools/ChangeLog:10
> +        * Scripts/run-api-tests: Launch the iOS Simulator before starting the iOS Simulator API tests and quit it after finishing the tests.
> +        * Scripts/webkitdirs.pm: Store string "For WebKit Development" to constant SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.

These lines are long. We tend to wrap lines longer than 100 characters in a ChangeLog entry.

>> Tools/Scripts/run-api-tests:100
>> +relaunchIOSSimulator(findOrCreateSimulatorForIOSDevice(SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT)) if willUseIOSSimulatorSDKWhenBuilding();
> 
> The simulator is not stopped if dumpTestsBySuite() is called below.
> 
> I think this line should move down to just before the 'exit' line, or into runTestsBySuite() if dumpTestsBySuite() does not need the simulator running.

We may want to consider adding a FIXME comment above this that explains that we are launch/quit the iOS Simulator as a workaround for <rdar://problem/22388812>.

> Tools/Scripts/run-api-tests:162
> +    quitIOSSimulator() if willUseIOSSimulatorSDKWhenBuilding();

We should put this logic inside an END block to ensure that we always run this logic on program termination regardless of whether termination is caused by calling die() (which may be invoked in runTest()). We may also want to consider adding a FIXME comment above this that explains that we launch/quit the iOS Simulator as a workaround for <rdar://problem/22388812>.

You can read more about the END block at <http://perldoc.perl.org/perlmod.html#BEGIN%2c-UNITCHECK%2c-CHECK%2c-INIT-and-END>.

> Tools/Scripts/webkitdirs.pm:84
>         USE_OPEN_COMMAND
> +       SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT

Please swap the order of these lines so that this list is in sorted order according to the Unix sort command.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150827/ab7a3085/attachment-0001.html>