[Webkit-unassigned] [Bug 148155] Scroll snapping should trigger when receiving a momentum end wheel event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 09:05:12 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148155

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 259361
  --> https://bugs.webkit.org/attachment.cgi?id=259361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259361&action=review

Thanks for the review!

>> Source/WebCore/platform/cocoa/ScrollController.mm:571
>> +        }
> 
> It's not obvious to me why this is inside an "else". beginScrollSnapAnimation does set these variables, but not in all code paths.

Good point. I should be able to lift the logic to reset the delta window and override state out of the else clause, since we should be doing this anyway even if we don't trigger a glide here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150819/64edeb70/attachment.html>


More information about the webkit-unassigned mailing list