<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Scroll snapping should trigger when receiving a momentum end wheel event"
href="https://bugs.webkit.org/show_bug.cgi?id=148155#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Scroll snapping should trigger when receiving a momentum end wheel event"
href="https://bugs.webkit.org/show_bug.cgi?id=148155">bug 148155</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259361&action=diff" name="attach_259361" title="Patch">attachment 259361</a> <a href="attachment.cgi?id=259361&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259361&action=review">https://bugs.webkit.org/attachment.cgi?id=259361&action=review</a>
Thanks for the review!
<span class="quote">>> Source/WebCore/platform/cocoa/ScrollController.mm:571
>> + }
>
> It's not obvious to me why this is inside an "else". beginScrollSnapAnimation does set these variables, but not in all code paths.</span >
Good point. I should be able to lift the logic to reset the delta window and override state out of the else clause, since we should be doing this anyway even if we don't trigger a glide here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>