[Webkit-unassigned] [Bug 148155] Scroll snapping should trigger when receiving a momentum end wheel event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148155

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259361|review?                     |review+
              Flags|                            |

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 259361
  --> https://bugs.webkit.org/attachment.cgi?id=259361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259361&action=review

> Source/WebCore/platform/cocoa/ScrollController.mm:571
> +        else {
> +            snapState.clearInitialWheelDeltaWindow();
> +            snapState.m_shouldOverrideWheelEvent = false;
> +        }

It's not obvious to me why this is inside an "else". beginScrollSnapAnimation does set these variables, but not in all code paths.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150819/3f7a789b/attachment.html>