[Webkit-unassigned] [Bug 148085] [WinCairo] Accelerated compositing does not respect device scale factor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148085

--- Comment #4 from peavo at outlook.com ---
(In reply to comment #3)
> Comment on attachment 259171 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259171&action=review
> 
> r=me, with a few minor corrections.
> 

Thanks!

> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:165
> > +    double ty = (size.height() - size.height() / deviceScaleFactor()) / 2.0;
> 
> Is this to center the view?
> 

Yes, I will add a comment before landing.

> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.h:55
> > +    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& rectToPaint) override;
> 
> Please remove 'virtual' for any methods that are 'override'.

Ok, I will remove 'virtual' before landing :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150817/9d45cbf9/attachment.html>