[Webkit-unassigned] [Bug 148085] [WinCairo] Accelerated compositing does not respect device scale factor.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 17 12:41:46 PDT 2015


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #259171|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 259171
  --> https://bugs.webkit.org/attachment.cgi?id=259171

View in context: https://bugs.webkit.org/attachment.cgi?id=259171&action=review

r=me, with a few minor corrections.

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:165
> +    double ty = (size.height() - size.height() / deviceScaleFactor()) / 2.0;

Is this to center the view?

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.h:55
> +    virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& rectToPaint) override;

Please remove 'virtual' for any methods that are 'override'.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150817/a11a8a1c/attachment.html>

More information about the webkit-unassigned mailing list