<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Accelerated compositing does not respect device scale factor."
href="https://bugs.webkit.org/show_bug.cgi?id=148085#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Accelerated compositing does not respect device scale factor."
href="https://bugs.webkit.org/show_bug.cgi?id=148085">bug 148085</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=148085#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=259171&action=diff" name="attach_259171" title="Patch">attachment 259171</a> <a href="attachment.cgi?id=259171&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=259171&action=review">https://bugs.webkit.org/attachment.cgi?id=259171&action=review</a>
>
> r=me, with a few minor corrections.
> </span >
Thanks!
<span class="quote">> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:165
> > + double ty = (size.height() - size.height() / deviceScaleFactor()) / 2.0;
>
> Is this to center the view?
> </span >
Yes, I will add a comment before landing.
<span class="quote">> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.h:55
> > + virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& rectToPaint) override;
>
> Please remove 'virtual' for any methods that are 'override'.</span >
Ok, I will remove 'virtual' before landing :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>