<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Accelerated compositing does not respect device scale factor."
href="https://bugs.webkit.org/show_bug.cgi?id=148085">bug 148085</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #259171 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Accelerated compositing does not respect device scale factor."
href="https://bugs.webkit.org/show_bug.cgi?id=148085#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Accelerated compositing does not respect device scale factor."
href="https://bugs.webkit.org/show_bug.cgi?id=148085">bug 148085</a>
from <span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=259171&action=diff" name="attach_259171" title="Patch">attachment 259171</a> <a href="attachment.cgi?id=259171&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=259171&action=review">https://bugs.webkit.org/attachment.cgi?id=259171&action=review</a>
r=me, with a few minor corrections.
<span class="quote">> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:165
> + double ty = (size.height() - size.height() / deviceScaleFactor()) / 2.0;</span >
Is this to center the view?
<span class="quote">> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.h:55
> + virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& rectToPaint) override;</span >
Please remove 'virtual' for any methods that are 'override'.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>