[Webkit-unassigned] [Bug 147824] NetworkProcess: DNS prefetch happens in the Web Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147824

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258713|review?                     |review-
              Flags|                            |

--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 258713
  --> https://bugs.webkit.org/attachment.cgi?id=258713
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258713&action=review

> Source/WebCore/html/HTMLAnchorElement.cpp:257
> -                    prefetchDNS(document().completeURL(parsedURL).host());
> +                    document().frame()->loader().client().prefetchDNS(document().completeURL(parsedURL).host());

I think that the document can have a null frame here, in which case we'll crash. Please add a test case for this, and fix the crash if I'm right.

> Source/WebCore/loader/LinkLoader.cpp:101
> +            document.frame()->loader().client().prefetchDNS(href.host());

Ditto.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:632
> +        m_page->mainFrame().loader().client().prefetchDNS(downcast<Element>(*node).absoluteLinkURL().host());

Can m_page be null here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/a6dbc562/attachment.html>