<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824">bug 147824</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #258713 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NetworkProcess: DNS prefetch happens in the Web Process"
href="https://bugs.webkit.org/show_bug.cgi?id=147824">bug 147824</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=258713&action=diff" name="attach_258713" title="Updated patch">attachment 258713</a> <a href="attachment.cgi?id=258713&action=edit" title="Updated patch">[details]</a></span>
Updated patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=258713&action=review">https://bugs.webkit.org/attachment.cgi?id=258713&action=review</a>
<span class="quote">> Source/WebCore/html/HTMLAnchorElement.cpp:257
> - prefetchDNS(document().completeURL(parsedURL).host());
> + document().frame()->loader().client().prefetchDNS(document().completeURL(parsedURL).host());</span >
I think that the document can have a null frame here, in which case we'll crash. Please add a test case for this, and fix the crash if I'm right.
<span class="quote">> Source/WebCore/loader/LinkLoader.cpp:101
> + document.frame()->loader().client().prefetchDNS(href.host());</span >
Ditto.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:632
> + m_page->mainFrame().loader().client().prefetchDNS(downcast<Element>(*node).absoluteLinkURL().host());</span >
Can m_page be null here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>