[Webkit-unassigned] [Bug 147824] NetworkProcess: DNS prefetch happens in the Web Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147824

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 258713
  --> https://bugs.webkit.org/attachment.cgi?id=258713
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258713&action=review

>> Source/WebCore/html/HTMLAnchorElement.cpp:257
>> +                    document().frame()->loader().client().prefetchDNS(document().completeURL(parsedURL).host());
> 
> I think that the document can have a null frame here, in which case we'll crash. Please add a test case for this, and fix the crash if I'm right.

That's why I added && document().frame() to the previous if condition

>> Source/WebCore/loader/LinkLoader.cpp:101
>> +            document.frame()->loader().client().prefetchDNS(href.host());
> 
> Ditto.

Ditto.

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:632
>> +        m_page->mainFrame().loader().client().prefetchDNS(downcast<Element>(*node).absoluteLinkURL().host());
> 
> Can m_page be null here?

m_page is created in the constructor, and deleted in ::close(), so if we are here we should have a valid page, I can add an assert

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150811/563f32d2/attachment.html>