[Webkit-unassigned] [Bug 143872] [SOUP] Add initial implementation of NetworkProcess disk cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 10:27:55 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143872

--- Comment #22 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 251553
  --> https://bugs.webkit.org/attachment.cgi?id=251553
Use fast malloc/free in IOChannel too

View in context: https://bugs.webkit.org/attachment.cgi?id=251553&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:201
> +    WriteAsyncData* asyncData = new WriteAsyncData { this, data.soupBuffer(), completionHandler };

It would be nicer and safer to use std::unique_ptr instead of explicit new/delete for memory management.

auto asyncData = std::make_unique<WriteAsyncData>(...)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150424/ddb2efef/attachment.html>


More information about the webkit-unassigned mailing list