<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add initial implementation of NetworkProcess disk cache"
href="https://bugs.webkit.org/show_bug.cgi?id=143872#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add initial implementation of NetworkProcess disk cache"
href="https://bugs.webkit.org/show_bug.cgi?id=143872">bug 143872</a>
from <span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251553&action=diff" name="attach_251553" title="Use fast malloc/free in IOChannel too">attachment 251553</a> <a href="attachment.cgi?id=251553&action=edit" title="Use fast malloc/free in IOChannel too">[details]</a></span>
Use fast malloc/free in IOChannel too
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251553&action=review">https://bugs.webkit.org/attachment.cgi?id=251553&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:201
> + WriteAsyncData* asyncData = new WriteAsyncData { this, data.soupBuffer(), completionHandler };</span >
It would be nicer and safer to use std::unique_ptr instead of explicit new/delete for memory management.
auto asyncData = std::make_unique<WriteAsyncData>(...)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>