[Webkit-unassigned] [Bug 143872] [SOUP] Add initial implementation of NetworkProcess disk cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143872

--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #22)
> Comment on attachment 251553 [details]
> Use fast malloc/free in IOChannel too
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251553&action=review
> 
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:201
> > +    WriteAsyncData* asyncData = new WriteAsyncData { this, data.soupBuffer(), completionHandler };
> 
> It would be nicer and safer to use std::unique_ptr instead of explicit
> new/delete for memory management.
> 
> auto asyncData = std::make_unique<WriteAsyncData>(...)

I didn't do this because the pointer is passed as user data of a C callback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150426/4686694a/attachment.html>