[Webkit-unassigned] [Bug 142719] AX: richer text change notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142719

--- Comment #103 from Doug Russell <d_russell at apple.com> ---
(In reply to comment #102)
> Comment on attachment 251507 [details]
> Update from review
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251507&action=review
> 
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:400
> > +    NSMutableArray *mutableArray = [array mutableCopy];
> 
> A shame that this function makes a mutable copy of the array in the almost
> 100% common case where it does contain only JSON types.
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:419
> > +    NSMutableDictionary *mutableDictionary = [dictionary mutableCopy];
> 
> A shame that this function makes a mutable copy of the dictionary in the
> almost 100% common case where it does contain only JSON types.
> 

Currrently the only methods that pass a non nil userInfo always include non JSON types. We could definitely make the copy conditional if that changes.

> 
> > Source/WebCore/editing/CompositeEditCommand.cpp:179
> > +    default:
> > +        break;
> 
> Normally we omit the default so we get a warning when we add a new enum
> value and don’t yet handle it in this switch statement.
> 
> > Source/WebCore/editing/EditCommand.cpp:133
> > +    default:
> > +        break;
> 
> Same comment about default as above.

There are a lot of EditActions that aren't accessibility relevant that the default covers.

> > Source/WebCore/editing/InsertIntoTextNodeCommand.h:44
> > +    const String& insertedText();
> > +protected:
> > +    InsertIntoTextNodeCommand(PassRefPtr<Text> node, unsigned offset, const String& text, EditAction editingAction);
> 
> Missing blank line before protected. Also, should just make this private
> again. I believe the reason to make it protected is obsolete.

This needs to be protected for ReplaceInsertIntoTextNodeCommand

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150424/68330dbe/attachment.html>