<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: richer text change notifications"
href="https://bugs.webkit.org/show_bug.cgi?id=142719#c103">Comment # 103</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: richer text change notifications"
href="https://bugs.webkit.org/show_bug.cgi?id=142719">bug 142719</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=142719#c102">comment #102</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=251507&action=diff" name="attach_251507" title="Update from review">attachment 251507</a> <a href="attachment.cgi?id=251507&action=edit" title="Update from review">[details]</a></span>
> Update from review
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251507&action=review">https://bugs.webkit.org/attachment.cgi?id=251507&action=review</a>
>
>
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:400
> > + NSMutableArray *mutableArray = [array mutableCopy];
>
> A shame that this function makes a mutable copy of the array in the almost
> 100% common case where it does contain only JSON types.
>
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:419
> > + NSMutableDictionary *mutableDictionary = [dictionary mutableCopy];
>
> A shame that this function makes a mutable copy of the dictionary in the
> almost 100% common case where it does contain only JSON types.
> </span >
Currrently the only methods that pass a non nil userInfo always include non JSON types. We could definitely make the copy conditional if that changes.
<span class="quote">>
> > Source/WebCore/editing/CompositeEditCommand.cpp:179
> > + default:
> > + break;
>
> Normally we omit the default so we get a warning when we add a new enum
> value and don’t yet handle it in this switch statement.
>
> > Source/WebCore/editing/EditCommand.cpp:133
> > + default:
> > + break;
>
> Same comment about default as above.</span >
There are a lot of EditActions that aren't accessibility relevant that the default covers.
<span class="quote">> > Source/WebCore/editing/InsertIntoTextNodeCommand.h:44
> > + const String& insertedText();
> > +protected:
> > + InsertIntoTextNodeCommand(PassRefPtr<Text> node, unsigned offset, const String& text, EditAction editingAction);
>
> Missing blank line before protected. Also, should just make this private
> again. I believe the reason to make it protected is obsolete.</span >
This needs to be protected for ReplaceInsertIntoTextNodeCommand</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>