[Webkit-unassigned] [Bug 144001] Make FunctionRareData allocation thread-safe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 14:16:04 PDT 2015


--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 251483
  --> https://bugs.webkit.org/attachment.cgi?id=251483
Too many different working directories are bad for your health

View in context: https://bugs.webkit.org/attachment.cgi?id=251483&action=review

> Source/JavaScriptCore/runtime/JSFunction.h:127
> +        FunctionRareData* rareData = m_rareData.get();
> -        return m_rareData.get()->allocationStructure();
> +        // The JS thread may be concurrently creating the rare data
> +        // If we see it, we want to ensure it has been properly created
> +        WTF::loadLoadFence();

Sometimes, we load this pointer in JIT code. Does our JIT code need to include a load-load fence?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150423/7320e1bc/attachment.html>

More information about the webkit-unassigned mailing list