<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Make FunctionRareData allocation thread-safe"
href="https://bugs.webkit.org/show_bug.cgi?id=144001#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Make FunctionRareData allocation thread-safe"
href="https://bugs.webkit.org/show_bug.cgi?id=144001">bug 144001</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251483&action=diff" name="attach_251483" title="Too many different working directories are bad for your health">attachment 251483</a> <a href="attachment.cgi?id=251483&action=edit" title="Too many different working directories are bad for your health">[details]</a></span>
Too many different working directories are bad for your health
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251483&action=review">https://bugs.webkit.org/attachment.cgi?id=251483&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/JSFunction.h:127
> + FunctionRareData* rareData = m_rareData.get();
>
> - return m_rareData.get()->allocationStructure();
> + // The JS thread may be concurrently creating the rare data
> + // If we see it, we want to ensure it has been properly created
> + WTF::loadLoadFence();</span >
Sometimes, we load this pointer in JIT code. Does our JIT code need to include a load-load fence?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>