[Webkit-unassigned] [Bug 144001] Make FunctionRareData allocation thread-safe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 14:28:38 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144001

--- Comment #10 from Basile Clement <basile_clement at apple.com> ---
Comment on attachment 251483
  --> https://bugs.webkit.org/attachment.cgi?id=251483
Too many different working directories are bad for your health

View in context: https://bugs.webkit.org/attachment.cgi?id=251483&action=review

>> Source/JavaScriptCore/runtime/JSFunction.h:127
>> +        WTF::loadLoadFence();
> 
> Sometimes, we load this pointer in JIT code. Does our JIT code need to include a load-load fence?

The load-load fence is only needed if there is possibly a concurrent thread writing to that pointer. 
The only thread writing to the pointer being the JS thread, which is also the only thread running the JIT code (as far as I understand), no fence should be needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150423/a994afa5/attachment.html>


More information about the webkit-unassigned mailing list