[Webkit-unassigned] [Bug 143953] [Curl] Favicons loaded from disc cache are ignored.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143953

--- Comment #3 from peavo at outlook.com ---
(In reply to comment #2)
> Comment on attachment 251165 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251165&action=review
> 
> > Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:177
> >  void CurlCacheEntry::setResponseFromCachedHeaders(ResourceResponse& response)
> >  {
> > -    response.setHTTPStatusCode(304);
> > +    response.setHTTPStatusCode(200);
> > +    response.setHTTPStatusText("OK");
> 
> 304 is the status of the response from the servers.  If a 304 is received
> from a server, then we as the browser want to tell the webpage that we got a
> 200 OK, right?  This makes sense, but it seems like it would've been a
> bigger problem.  Why wasn't this noticed before?

Yes, it seems like it is only the icon loader which does not accept a 304 response. There is no problem responding with 304 for a cached document or image.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/a32b44f4/attachment.html>